[ug02fast]

Hi everyone, i've recently been trying to learn some php and mysql. I have actually been working from a book called PHP & MySQL the missing manual. Well i got far and was doing good until my images would not display after uploading.

Could anyone take a look at my code and point out what is wrong? I'm really noob at this whole thing, I got the image to upload to my sql table but the image doesn't display after uploading.

PHP Code:

<?php

require_once 'app_config.php';
require_once 'database_connection.php';

$upload_dir = SITE_ROOT . "uploads/profile_pics/";
$image_fieldname = "user_pic";

// Potential PHP upload errors
$php_errors = array(1 => 'Maximum file size in php.ini exceeded',
                    2 => 'Maximum file size in HTML form exceeded',
                    3 => 'Only part of the file was uploaded',
                    4 => 'No file was selected to upload.');

$first_name = trim($_REQUEST['first_name']);
$last_name = trim($_REQUEST['last_name']);
$email = trim($_REQUEST['email']);
$bio = trim($_REQUEST['bio']);
$facebook_url = str_replace("facebook.org", "facebook.com", trim($_REQUEST['facebook_url']));
$position = strpos($facebook_url, "facebook.com");
if ($position === false) {
  $facebook_url = "http://www.facebook.com/" . $facebook_url;
}

$twitter_handle = trim($_REQUEST['twitter_handle']);
$twitter_url = "http://www.twitter.com/";
$position = strpos($twitter_handle, "@");
if ($position === false) {
  $twitter_url = $twitter_url . $twitter_handle;
} else {
  $twitter_url = $twitter_url . substr($twitter_handle, $position + 1);
}

// Make sure we didn't have an error uploading the image
($_FILES[$image_fieldname]['error'] == 0)
  or handle_error("the server couldn't upload the image you selected.",
                  $php_errors[$_FILES[$image_fieldname]['error']]);

// Is this file the result of a valid upload?
@is_uploaded_file($_FILES[$image_fieldname]['tmp_name'])
  or handle_error("you were trying to do something naughty. Shame on you!",
                  "Uploaded request: file named '{$_FILES[$image_fieldname]['tmp_name']}'");

// Is this actually an image?
@getimagesize($_FILES[$image_fieldname]['tmp_name'])
  or handle_error("you selected a file for your picture that isn't an image.",
                  "{$_FILES[$image_fieldname]['tmp_name']} isn't a valid image file.");

// Name the file uniquely
$now = time();
while (file_exists($upload_filename = $upload_dir . $now .
                                     '-' .
                                     $_FILES[$image_fieldname]['name'])) {
    $now++;
}

echo $upload_filename;
echo "<br />";
echo $_FILES[$image_fieldname]['tmp_name'];

// Finally, move the file to its permanent location
@move_uploaded_file($_FILES[$image_fieldname]['tmp_name'], $upload_filename)
  or handle_error("we had a problem saving your image to its permanent location.",
                  "permissions or related error moving file to {$upload_filename}");

$insert_sql = "INSERT INTO users (first_name, last_name, email, bio, facebook_url, twitter_handle, user_pic_path) " .
              "VALUES ('{$first_name}', '{$last_name}', '{$email}', '{$bio}', " .
                      "'{$facebook_url}', '{$twitter_handle}', '{$upload_filename}');";

// Insert the user into the database
mysql_query($insert_sql);

// Redirect the user to the page that displays user information
header("Location: show_user.php?user_id=" . mysql_insert_id());
?>

When I upload the image it shows up as a broken image and does not display the image.

I personally think it has something to do with
$upload_dir = SITE_ROOT . "uploads/profile_pics/";

but I am just not sure.
The site is http://splash.comuf.com/create_user.html if you could look at that aswell.

I really really appreciate if anyone could help me out.

[grace1004]

I personally think it has something to do with
$upload_dir = SITE_ROOT . "uploads/profile_pics/";

Please try after changing as shown below:

$upload_dir = dirname(_FILE_)."/uploads/profile_pics";

[ug02fast]

Originally Posted by grace1004

Please try after changing as shown below:

$upload_dir = dirname(_FILE_)."/uploads/profile_pics";

I love you.

Works!

Thank you so much!